Fix crash counting messages with null content (tool-call logs) - #238
Open
eeshsaxena wants to merge 1 commit into
Open
Fix crash counting messages with null content (tool-call logs)#238eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
OpenAI's chat schema allows content to be null, most commonly on an assistant message that only carries tool_calls. count_message_tokens passed every field value straight to encoding.encode(), so a None value raised TypeError: expected string or buffer, taking down calculate_prompt_cost with it. Skip None values (they add no text tokens) and add a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
count_message_tokens(and thereforecalculate_prompt_cost) crashes on a normal OpenAI message wherecontentis null:OpenAI's chat schema makes
contentnullable, and an assistant message that only carriestool_callshascontent: null. The counting loop passes every field value straight intoencoding.encode(value), which raisesTypeErroronNone. So any pipeline that estimates cost over real conversation logs with tool calls hits this.A null field adds no text tokens, so the fix skips
Nonevalues. Counting a null content now matches counting an empty string. Added a test.