Skip to content

Handle circular references in jsonability checks #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodingFeng101 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle circular references in jsonability checks #1416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agentops/helpers/serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def is_jsonable(x):
try:
json.dumps(x)
return True
except (TypeError, OverflowError):
except (TypeError, OverflowError, ValueError):
return False


Expand Down
5 changes: 1 addition & 4 deletions tests/unit/test_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,7 @@ def test_circular_reference(self):
a["b"] = b
b["a"] = a

# The current implementation doesn't handle ValueError from circular references
# So this will raise an exception instead of returning False
with pytest.raises(ValueError, match="Circular reference detected"):
is_jsonable(a)
assert is_jsonable(a) is False


# Define test cases for filter_unjsonable
Expand Down