Conversation
|
|
Member
|
Hey, thanks for the PR. Could you sign the CLA when you get a chance so we can review it? |
Author
|
Thanks for the reminder. I have already signed the CLA, but CLA Assistant is still showing it as pending on this PR. I’ll retry its recheck flow; if it continues to block review, please let me know what additional step is needed. I also added the suggested one-line Unreleased changelog entry in the latest commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
docs/benchmarks/performance/measure-cli.sh.Fixes #1446
How it was checked
go build ./...— passed (Windows, Go 1.26.5).go test ./docs/benchmarks/performance -count=1andgo vet ./docs/benchmarks/performance— passed.measure-cli.sh --helpexamples from the repository root with Git Bash — usage printed.git diff --check— passed.The broader Windows checks are not fully clean:
go vet ./...and some manual/law test packages reference Unix-onlysyscall.Kill/unix.Flock; separate existing UI/law assertions also fail on this checkout. GNUmakeis not installed here, so I could not run the repository wrappermake pr-ready. These failures are outside the changed files; CI on Linux is still needed.