Skip to content

tests: TestHandingAYourCallToTheModelAndItsResolveAreOneRoad fails 4 in 900 #1526

Description

@AbirAbbas

What happened

TestHandingAYourCallToTheModelAndItsResolveAreOneRoad (internal/session/tools_tasks_test.go) fails intermittently: 4 in 900 runs on dev@691ade547, and 2 in 900 on a branch that doesn't touch it. It turned one PR's CI red on 2026-09-25, and a rerun passed.

Replication

go test -count=900 -run 'TestHandingAYourCallToTheModelAndItsResolveAreOneRoad' ./internal/session

A few failures in 900 is typical.

The fix

Find the race. Timing flakes in this package have had a real cause before (#176), so fix that cause rather than retrying.

Acceptance

  • Unit: 0 failures in -count=2000, and 0 under -race -count=200.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:testsThe suite itself — flakes, harnesses, laws, CI redsbugSomething the code does that it should not

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions