Skip to content

Fix traversal of semantic AST children#285

Merged
git-hulk merged 2 commits into
masterfrom
codex/fix-semantic-traversal
Jul 5, 2026
Merged

Fix traversal of semantic AST children#285
git-hulk merged 2 commits into
masterfrom
codex/fix-semantic-traversal

Conversation

@git-hulk

@git-hulk git-hulk commented Jul 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Traverse semantic AST children that were skipped by both Accept and Walk: ColumnDef.CompressionCodec, TTLPolicyRule.Action, and WithTimeoutClause.Expr.
  • Make WithTimeoutClause tolerate expression-backed values in End, Accept, and formatting.
  • Add a static traversal drift guard for semantic AST fields so future omissions are caught even when both traversal engines miss the same field.

Verification

  • go test ./parser -run 'TestTraversalEnginesVisitAllSemanticFields|TestTraversalEnginesVisitSameFields|TestTraversalVisitsJSONTypeOptions|TestVisitJoinTableExprWithSampleRatio|TestWalkVisitsInsertValues|TestDestinationTableSchemaVisitedOnce'
  • go test ./...
  • git diff --check
  • make test

Notes

  • make lint currently fails before linting because the local golangci-lint cannot load this repo config: unsupported version of the configuration: "".
  • SQL rewrite / Transform implementation work is intentionally excluded from this PR for separate review.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@git-hulk
git-hulk merged commit e4c6e11 into master Jul 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant