Potential fix for code scanning alert no. 2: Information exposure through an exception - #288
Open
Exohayvan wants to merge 1 commit into
Open
Potential fix for code scanning alert no. 2: Information exposure through an exception#288Exohayvan wants to merge 1 commit into
Exohayvan wants to merge 1 commit into
Conversation
…ough an exception Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Exohayvan
marked this pull request as ready for review
July 23, 2026 02:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/AetherMesh-AI/aethermesh-core/security/code-scanning/2
To fix this safely without changing endpoint behavior, keep returning stable
reason_codevalues but replace client-facingreasontext derived from exceptions with generic, non-sensitive messages. Log detailed exception information on the server for debugging.Best single approach here:
src/aethermesh_core/runtime_service.py, add a module logger.preflight_local_result_reportexception handlers:logger.exception(...)(includes traceback in server logs)._reject_local_result_reportwith a generic user-safe reason string instead ofstr(exc).status,attempt_id,reason_code, etc.) so functionality remains the same from an API-contract perspective, while removing sensitive exception content from responses.This addresses both variants (line 1309 and 1311 exception sources), since both currently pass
str(exc)to the returned rejection payload.Suggested fixes powered by Copilot Autofix. Review carefully before merging.