Setup and add integration tests - #2043
Open
gcatanese wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request establishes a dedicated integration testing framework under src/integration-test, introducing Maven profiles, configuration templates, guidelines, and several integration tests for Adyen APIs. It also renames the existing test base class to BaseCloudDeviceIntegrationTest to prevent naming conflicts. The review feedback suggests improving thread safety in BaseIntegrationTest by using ConcurrentHashMap for caching clients, and enhancing robustness in BaseCloudDeviceIntegrationTest by avoiding direct getClassLoader() calls when loading resource streams.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Setup integration tests:
Tests do not run on GitHub, they will be enabled in a different PR.
Tested scenarios
Run all tests locally