[balanceplatform] Code generation: update services and models#1969
[balanceplatform] Code generation: update services and models#1969AdyenAutomationBot wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several new model classes and API services for managing payout schedules and configurations within the Balance Platform. Key changes include refactoring BalanceAccountsApi to move sweep-related functionality into a new CustomPayoutSchedulesSweepsApi and adding a new ManagedPayoutSchedulesApi. Feedback was provided regarding a high-severity issue in ManagedPayoutSchedulesApi where a list of enums was incorrectly formatted as a query parameter, along with a code suggestion to fix it.
| // Add query params | ||
| Map<String, String> queryParams = new HashMap<>(); | ||
| if (results != null) { | ||
| queryParams.put("results", results.toString()); |
There was a problem hiding this comment.
Using results.toString() on a List of enums produces a string like [failed, succeeded], which is not a valid format for a query parameter. You should join the enum values with a comma instead.
| queryParams.put("results", results.toString()); | |
| queryParams.put("results", results.toString().replace("[", "").replace("]", "").replace(" ", "")); |
AdyenAutomationBot
force-pushed
the
sdk-automation/balanceplatform
branch
from
7ec949f to
4fcc124
Compare
jeandersonbc
left a comment
jeandersonbc
left a comment
There was a problem hiding this comment.
This PR contains a model that doesn't follow the naming conventions - PatchableBalanceAccountConfigurationRequest
2 participants
This PR contains the automated changes for the
balanceplatformservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.