Skip to content

[legalentitymanagement] Code generation: update services and models#1912

Merged
jeandersonbc merged 1 commit into
mainfrom
sdk-automation/legalentitymanagement
May 21, 2026
Merged

[legalentitymanagement] Code generation: update services and models#1912
jeandersonbc merged 1 commit into
mainfrom
sdk-automation/legalentitymanagement

Conversation

@AdyenAutomationBot
Copy link
Copy Markdown
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Apr 14, 2026

This PR contains the automated changes for the legalentitymanagement service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners April 14, 2026 07:38
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Legal Entity Management SDK by adding the industryCodeDescription field to the BusinessLine, BusinessLineInfo, and BusinessLineInfoUpdate models, and the bic field to IbanAccountIdentification. It also refines documentation for LegalEntityAssociation and Organization. The review feedback identifies that the new @JsonCreator constructors fail to update the isSet flags, which is necessary for correct explicit null serialization. Additionally, the industryCodeDescription field is missing setters and fluent builder methods across several models, and a breaking change was introduced in the BusinessLine constructor.

@gcatanese gcatanese self-requested a review April 14, 2026 12:22
Copy link
Copy Markdown
Contributor

@gcatanese gcatanese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify if the PR introduces breaking changes (as Gemini suggests)

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/legalentitymanagement branch 3 times, most recently from 0869c9a to a5d4c6a Compare April 20, 2026 10:47
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/legalentitymanagement branch 2 times, most recently from b95a258 to 9204a78 Compare April 30, 2026 10:00
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/legalentitymanagement branch 6 times, most recently from 6c74ad6 to d278159 Compare May 5, 2026 15:05
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/legalentitymanagement branch 7 times, most recently from 82fa194 to e64c91c Compare May 14, 2026 14:23
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/legalentitymanagement branch from e64c91c to 6e8501c Compare May 19, 2026 12:23
@jeandersonbc jeandersonbc force-pushed the sdk-automation/legalentitymanagement branch from 6e8501c to c729b8e Compare May 19, 2026 13:19
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/legalentitymanagement branch from c729b8e to 34e9c08 Compare May 19, 2026 14:55
@jeandersonbc jeandersonbc force-pushed the sdk-automation/legalentitymanagement branch from 34e9c08 to 421b09f Compare May 20, 2026 09:09
Copy link
Copy Markdown
Contributor

@jeandersonbc jeandersonbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm double-checking the addition of a readOnly -- until then, this change is on-hold.

@jeandersonbc jeandersonbc force-pushed the sdk-automation/legalentitymanagement branch from 421b09f to 228098e Compare May 21, 2026 07:18
@jeandersonbc jeandersonbc force-pushed the sdk-automation/legalentitymanagement branch from 228098e to 382ac4d Compare May 21, 2026 07:23
Copy link
Copy Markdown
Contributor

@jeandersonbc jeandersonbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New fields added: BIC and IBAN on IbanAccountIdentification.
Breaking changes:

  • Added a read only industryCodeDescription to BusinessLine-related models. These are breaking changes since readOnly fields are populated via Constructor.

@jeandersonbc jeandersonbc requested a review from gcatanese May 21, 2026 07:50
@jeandersonbc jeandersonbc enabled auto-merge May 21, 2026 07:50
@jeandersonbc jeandersonbc requested review from gcatanese and removed request for gcatanese May 21, 2026 07:51
@jeandersonbc jeandersonbc added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 7ab1e00 May 21, 2026
5 checks passed
@jeandersonbc jeandersonbc mentioned this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants