[legalentitymanagement] Code generation: update services and models#1912
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Legal Entity Management SDK by adding the industryCodeDescription field to the BusinessLine, BusinessLineInfo, and BusinessLineInfoUpdate models, and the bic field to IbanAccountIdentification. It also refines documentation for LegalEntityAssociation and Organization. The review feedback identifies that the new @JsonCreator constructors fail to update the isSet flags, which is necessary for correct explicit null serialization. Additionally, the industryCodeDescription field is missing setters and fluent builder methods across several models, and a breaking change was introduced in the BusinessLine constructor.
gcatanese
left a comment
There was a problem hiding this comment.
Verify if the PR introduces breaking changes (as Gemini suggests)
0869c9a to
a5d4c6a
Compare
b95a258 to
9204a78
Compare
6c74ad6 to
d278159
Compare
82fa194 to
e64c91c
Compare
e64c91c to
6e8501c
Compare
6e8501c to
c729b8e
Compare
c729b8e to
34e9c08
Compare
34e9c08 to
421b09f
Compare
jeandersonbc
left a comment
There was a problem hiding this comment.
I'm double-checking the addition of a readOnly -- until then, this change is on-hold.
421b09f to
228098e
Compare
228098e to
382ac4d
Compare
jeandersonbc
left a comment
There was a problem hiding this comment.
New fields added: BIC and IBAN on IbanAccountIdentification.
Breaking changes:
- Added a read only industryCodeDescription to BusinessLine-related models. These are breaking changes since readOnly fields are populated via Constructor.
This PR contains the automated changes for the
legalentitymanagementservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.