mask-risc: charge strided predicates' extra passes in op_histogram - #1286
Merged
Merged
Conversation
The strided predicates have no *_under kernel, so the executor runs a gated one as the strided kernel plus mask_and_assign, and NeU32Strided is always the eq kernel plus mask_not_assign. op_histogram sent all three through the generic predicate arm, so mask_passes() under-reported gated Eq/Match by one and Ne by one or two. They are now charged like the gated Range: the gate's and to two_input, Ne's complement to not. Test pins every case, with the ungated Eq/Match silence twin; disable-verified (dropping the arm fails it). Codex P2 on #1284. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DCEP2fZdHYdMCtcEVcTpS2
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d92d05cf-4ddb-4ba7-a8a3-0ebf3f7f7e3c) |
AdaWorldAPI
marked this pull request as ready for review
September 25, 2026 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1284, fixing the Codex P2 on it.
The problem. The strided predicates have no
*_underkernel. So the executor runs a gated one as the strided kernel followed bymask_and_assign.NeU32Stridedis also always the eq kernel followed bymask_not_assign.Program::op_histogramsent all three through the generic predicate arm, somask_passes()under-reported:The fix. They are now charged the same way the gated
Rangealready is: the gate'sandgoes totwo_input, and Ne's complement goes tonot.Tests.
op_histogram_charges_the_strided_predicates_extra_passespins every case, plus the silence twin: an ungated Eq or Match is one predicate and zero mask passes.cargo test -p lance-graph-mask-risc: 122 passed. Clippy and fmt are clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01DCEP2fZdHYdMCtcEVcTpS2
Generated by Claude Code