quack: refuse an empty group universe in lower_group_avg; record lancedb remote cost - #1285
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
…ion-pr-wave-s57uj7
Codex P2 on #1282 (Pair arm), and wider than reported: the count half is GroupReduce Count for every key kind, and that terminal needs a non-empty Out::I64, so a groups == 0 plan could never execute for Local or Via keys either. Reject with LowerError::EmptyGroupUniverse, as lower_group_having already does. Test covers Local and Pair, both directions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_a155aa7b-0e9b-4980-9c42-702eaaaafaf1) |
AdaWorldAPI
marked this pull request as ready for review
September 25, 2026 02:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1282, which merged before these two commits.
lower_group_avgrefusesgroups == 0(codex P2 on #1282)Codex flagged the new Pair arm. The problem is wider: the count half of every AVG plan is
GroupReduce Count, and that terminal needs a non-emptyOut::I64. So a K = 0 plan could never execute for Local and Via keys either, and the zero case was accepted for all of them. The function now returnsLowerError::EmptyGroupUniversefor every key kind, the same aslower_group_having.lower_group_avg_refuses_an_empty_group_universe_for_every_key_kind. It covers Local and Pair keys, and asserts both that K = 0 is refused and that K = 1 lowers.Local(Col(1)):OkwhereErrwas expected). A disable run that deletes the guard turns it red again.-D warningsclean.The
remotefeature's cost, recorded (stranded from #1282)crates/lance-graph/Cargo.tomland the sweep's board entry now record the measured cost of lancedb'sremotefeature. Measured withcargo tree -p lance-graph --features lancedb-sdk, it adds 10 crates (630 vs 620):This part is a comment and documentation only; no behaviour changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_01GXUahz73MZxtxWcfpHp9dG
Generated by Claude Code