Correct ethernet registers errors due to incorrect SVD file#458
Open
pat-rogers wants to merge 1 commit intoAdaCore:masterfrom
Open
Correct ethernet registers errors due to incorrect SVD file#458pat-rogers wants to merge 1 commit intoAdaCore:masterfrom
pat-rogers wants to merge 1 commit intoAdaCore:masterfrom
Conversation
pat-rogers
changed the title
pat-rogers
changed the title
* for the Ethernet MAC frame filter register, ie MACFFR_Register, correct a component name, a type, and a size in MACFFR_Register to match the documentation. Component "RAM" should be "PAM", and PCF should be a 2-bit quantity (requiring a change to the size of the unused bits reserved at the end) * for the Ethernet MAC debug register, ie MACDBGR_Register, the package from SVD does not correspond to the documentation at all. Therefore we change this register definition manually. See RM0385 Rev 8 pages 1610 and 1611. * likewise, for the Ethernet MAC MII data register, ie MACMIIDR_Register, change component name to match documentation We also need to change the SVD file itself, in the svd2ada project.
pat-rogers
force-pushed
the
ethernet_svd_registers_errors
branch
from
7b1f111 to
3c54b39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In stm32_svd-ethernet.ads for F7x:
for the Ethernet MAC frame filter register, ie MACFFR_Register, correct a component name, a type, and a size in MACFFR_Register to match the documentation. Component "RAM" should be "PAM", and PCF should be a 2-bit quantity (requiring a change to the size of the unused bits reserved at the end). See RM0385 Rev 8 Table 282 page1646.
for the Ethernet MAC debug register, ie MACDBGR_Register, the package from SVD does not correspond to the documentation at all. Therefore we change this register definition manually. See RM0385 Rev 8 pages 1610 and 1611.
likewise, for the Ethernet MAC MII data register, ie MACMIIDR_Register, change component name to match documentation. See RM0385 Rev 8 Table 282 page1646.
We also need to change the SVD file itself, in the svd2ada project.