fix(android): update JNI androidQuery bucket name to aw-watcher-android#632
Open
0xbrayo wants to merge 1 commit into
Open
fix(android): update JNI androidQuery bucket name to aw-watcher-android#6320xbrayo wants to merge 1 commit into
0xbrayo wants to merge 1 commit into
Conversation
…ucket name This fixes an issue introduced in ActivityWatch#628 where the legacy '-test' suffix was dropped from buckets but not from the query.
Greptile SummaryThis PR updates the Android JNI query bucket name. The main change is:
Confidence Score: 4/5The Android query path can fail for existing users until the separate bucket migration has run.
aw-server/src/android/mod.rs Important Files Changed
Reviews (1): Last reviewed commit: "fix(android): update JNI androidQuery to..." | Re-trigger Greptile |
| // Hardcoded bucket ID for testing | ||
| let bid_android = "aw-watcher-android-test".to_string(); | ||
| // Hardcoded bucket ID | ||
| let bid_android = "aw-watcher-android".to_string(); |
There was a problem hiding this comment.
Unmigrated Buckets Stop Querying
When androidQuery runs before migrateWatcherAndroidBucketNames has renamed existing aw-watcher-android-test... buckets, the new aw-watcher-android filter no longer matches the only stored Android watcher bucket. That makes the JNI query return an error JSON instead of the user's events until the separate migration entry point has run successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ActivityWatch/aw-android#191
This fixes an issue introduced in #628 where the legacy '-test' suffix was dropped from buckets but not from the query.