Skip to content

fix(ci): bump MACOSX_DEPLOYMENT_TARGET 10.9 -> 10.12#1327

Open
ErikBjare wants to merge 1 commit into
masterfrom
fix/ci-macos-deployment-target
Open

fix(ci): bump MACOSX_DEPLOYMENT_TARGET 10.9 -> 10.12#1327
ErikBjare wants to merge 1 commit into
masterfrom
fix/ci-macos-deployment-target

Conversation

@ErikBjare

Copy link
Copy Markdown
Member

rustc no longer supports a macOS deployment target below 10.12. Every Rust compile in the macOS Qt and Tauri jobs currently emits:

warning: deployment target in MACOSX_DEPLOYMENT_TARGET was set to 10.9, but the minimum supported by `rustc` is 10.12

~36 occurrences per release run. macOS 10.9–10.11 are long past Apple's support window (10.12 Sierra is from 2016), so raise the floor to 10.12 to silence the warnings. No functional change to supported targets in practice.

rustc no longer supports a macOS deployment target below 10.12, so every
Rust compile in the macOS jobs emitted:

  warning: deployment target in MACOSX_DEPLOYMENT_TARGET was set to 10.9,
  but the minimum supported by `rustc` is 10.12

(36 occurrences per release run). 10.9/10.10/10.11 are long past Apple's
support window, so raise the floor to silence the warnings.
@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR raises MACOSX_DEPLOYMENT_TARGET from 10.9 to 10.12 in both the build-qt and build-tauri CI jobs to silence rustc warnings about unsupported deployment targets. macOS 10.9–10.11 are long past Apple's end-of-life window, so this has no practical impact on supported targets.

  • build-qt job (line 231): MACOSX_DEPLOYMENT_TARGET bumped from 10.910.12, eliminating ~18 rustc warnings per release run.
  • build-tauri job (line 418): Same bump, eliminating ~18 more warnings. Both changes are job-level env vars and apply only when running on macOS runners.

Confidence Score: 5/5

Safe to merge — a one-line env var bump in each of two CI jobs, with no logic changes and no impact on non-macOS runners.

Both changes are isolated to job-level environment variables that are only meaningful on macOS runners. The new value (10.12) is exactly what rustc requires as its minimum, the old value (10.9) was already being silently upgraded by the toolchain, and macOS 10.9–10.11 have been unsupported by Apple for years. No build steps, dependencies, or artifacts are affected beyond silencing the warnings.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/release.yml Bumps MACOSX_DEPLOYMENT_TARGET from 10.9 to 10.12 in both the build-qt and build-tauri job environments — a correct, minimal fix for rustc compatibility warnings with no functional regressions.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[release.yml workflow trigger] --> B[build-qt job]
    A --> C[build-tauri job]

    B --> B1["env: MACOSX_DEPLOYMENT_TARGET=10.12 ✅\n(was 10.9)"]
    B1 --> B2["matrix: ubuntu-24.04\nwindows-latest\nmacos-latest"]
    B2 --> B3[Rust compile — no rustc warning]

    C --> C1["env: MACOSX_DEPLOYMENT_TARGET=10.12 ✅\n(was 10.9)"]
    C1 --> C2["matrix: ubuntu-24.04\nubuntu-24.04-arm\nwindows-latest\nmacos-latest"]
    C2 --> C3[Rust compile — no rustc warning]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[release.yml workflow trigger] --> B[build-qt job]
    A --> C[build-tauri job]

    B --> B1["env: MACOSX_DEPLOYMENT_TARGET=10.12 ✅\n(was 10.9)"]
    B1 --> B2["matrix: ubuntu-24.04\nwindows-latest\nmacos-latest"]
    B2 --> B3[Rust compile — no rustc warning]

    C --> C1["env: MACOSX_DEPLOYMENT_TARGET=10.12 ✅\n(was 10.9)"]
    C1 --> C2["matrix: ubuntu-24.04\nubuntu-24.04-arm\nwindows-latest\nmacos-latest"]
    C2 --> C3[Rust compile — no rustc warning]
Loading

Reviews (1): Last reviewed commit: "fix(ci): bump MACOSX_DEPLOYMENT_TARGET 1..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant