fix(webview): retain instance when destroy fails - #2836
Merged
RohitKushvaha01 merged 4 commits intoAug 31, 2026
Merged
Conversation
Contributor
Greptile SummaryThe PR preserves a WebView wrapper when native destruction fails while serializing concurrent destruction attempts through a shared promise.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Sequence DiagramsequenceDiagram
participant A as First caller
participant B as Concurrent caller
participant W as WebView wrapper
participant N as Native bridge
A->>W: destroy()
W->>N: destroy(id)
B->>W: destroy()
W-->>B: await shared promise
alt Native destruction succeeds
N-->>W: resolve
W->>W: mark destroyed and clear callbacks
W-->>A: resolve
W-->>B: resolve
else Native destruction fails
N-->>W: reject
W->>W: clear shared promise
W-->>A: reject
W-->>B: reject
end
Reviews (2): Last reviewed commit: "test(webview): cover concurrent destruct..." | Re-trigger Greptile |
This comment was marked as outdated.
This comment was marked as outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The WebView API currently sets "_destroyed" before awaiting the native bridge. If native destruction fails, the native WebView may still exist, but its JavaScript wrapper permanently rejects further operations—including another destruction attempt.
This change moves the state transition until after successful native destruction.
Testing
Related work
Follow-up to the WebView Plugin API introduced in #2525.