Skip to content

fix: terminal resize #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RohitKushvaha01 merged 3 commits into from
Jun 6, 2026
+18 −2
Merged

fix: terminal resize #2154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d844d76
fix: terminal resize
RohitKushvaha01 Jun 5, 2026
c65fb51
fix: terminal resize
RohitKushvaha01 Jun 5, 2026
ddbb651
format
RohitKushvaha01 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/components/terminal/terminalManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,15 +668,31 @@ class TerminalManager {
const RESIZE_DEBOUNCE = 200;
let lastResizeTime = 0;

let lastWidth = 0;
let lastHeight = 0;
let lastWidth = null;
let lastHeight = null;

const handleResize = (entries) => {
const now = Date.now();
const entry = entries && entries[0];
const cr = entry?.contentRect;
const width = cr?.width ?? terminalFile.content?.clientWidth ?? 0;
const height = cr?.height ?? terminalFile.content?.clientHeight ?? 0;

// Skip resize events when container is hidden (via any method: inline style, CSS class, etc.)
const isHidden =
getComputedStyle(terminalFile.content).display === "none" ||
terminalFile.content?.offsetHeight === 0;
if (isHidden) {
return;
}
Comment thread
RohitKushvaha01 marked this conversation as resolved.

if (lastWidth === null || lastHeight === null) {
lastWidth = width;
lastHeight = height;

return;
}

// Clear any pending resize
if (resizeTimeout) {
clearTimeout(resizeTimeout);
Expand Down