fix(package_cache): skip malformed variant json in get_variants - #2168
Open
Sanjays2402 wants to merge 1 commit into
Open
fix(package_cache): skip malformed variant json in get_variants#2168Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
A variant json file truncated or corrupted (eg by the cache disk filling up) made json.loads raise out of PackageCache.get_variants, so every rez-pkg-cache command that enumerates the cache - including --clean, which is what you would run to recover - crashed with a JSONDecodeError. Unreadable/corrupt variant json files are now skipped, matching how the pending-file loops in the same class already handle them. Closes AcademySoftwareFoundation#2016
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2016
A variant json file truncated by a full cache disk made
json.loadsraise straight out ofPackageCache.get_variants(), so everyrez-pkg-cachecommand that enumerates the cache crashed with aJSONDecodeError— including--clean, which is what you'd run to recover from exactly that situation.Corrupt/unreadable variant json files are now skipped, matching how the pending-file loops in the same class already handle them. New test writes an empty variant json and asserts
get_variants()returns cleanly; it fails with the reportedJSONDecodeErrorwithout the fix.