test: add unit tests for package_search.py - #2157
Closed
darrenhuai wants to merge 1 commit into
Closed
Conversation
ResourceSearcher and ResourceSearchResultFormatter had no dedicated tests. Covers family/package/variant resolution, glob matching, version ranges, latest-only, after_time/before_time filtering, and output_format abbreviation expansion. Refs AcademySoftwareFoundation#2092 Signed-off-by: darrenhuai <60621295+darrenhuai@users.noreply.github.com>
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package_search.py didn't have any tests - ResourceSearcher and ResourceSearchResultFormatter were both completely uncovered. Added tests for the search behavior (family/package/variant resolution, glob matching, version ranges, latest-only, after_time/before_time filtering) and the formatter (default qualified-name output, abbreviation expansion, ambiguous abbreviations left as-is, splitting on the literal newline token in output_format).
Reused the existing fixture packages under data/tests and the TestBase/TempdirMixin setup already used elsewhere in the suite, so no new test data needed.
Ran the full suite locally (321 passed), flake8 and ruff are both clean on the new file.
Refs #2092