Add Tree I/O Option#2201
Open
danrbailey wants to merge 3 commits into
Open
Conversation
danrbailey
requested review from
Idclip,
apradhana,
jmlait,
kmuseth and
richhones
as code owners
danrbailey
force-pushed
the
io_enable_tree_io
branch
from
f648d2b to
c3a6b5e
Compare
Signed-off-by: Dan Bailey <danbailey@ilm.com>
Signed-off-by: Dan Bailey <danbailey@ilm.com>
Signed-off-by: Dan Bailey <danbailey@ilm.com>
danrbailey
force-pushed
the
io_enable_tree_io
branch
from
c3a6b5e to
e232df3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a CMake option which defaults to ON (
OPENVDB_ENABLE_TREE_IO=ON) that enables the Tree I/O methods. By switching this off, it is possible to remove all the code paths that provide Tree I/O and thus rely solely on the new I/O codecs.Note that Itanium C++ ABI rules allow us to delete the virtual methods on the Grid and the Tree without changing the vtable layout.
In the future, we will disable Tree I/O by default and then ultimately remove it.