Fixes for API exports - #2039
Merged
darbyjohnston merged 2 commits intoSep 22, 2026
Merged
darbyjohnston merged 2 commits into
darbyjohnston merged 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2039 +/- ##
=======================================
Coverage 83.52% 83.52%
=======================================
Files 182 182
Lines 13533 13533
Branches 1255 1255
=======================================
Hits 11303 11303
Misses 2057 2057
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
darbyjohnston
force-pushed
the
windows-shared-exports
branch
from
September 11, 2026 02:03
44a92c5 to
a8b3015
Compare
meshula
approved these changes
Sep 22, 2026
meshula
left a comment
meshula
left a comment
Collaborator
There was a problem hiding this comment.
Hi Darby, this is all correct, thank you
OTIO_EXPORTS and OPENTIME_EXPORTS were PUBLIC, so everything consuming OTIO compiled its API as dllexport where it has to be dllimport. They become PRIVATE, which says the library is being built rather than consumed; the OTIO_STATIC and OPENTIME_STATIC definitions stay PUBLIC, since a consumer does have to know the API carries no declspec at all. With that corrected the members marked only at the class level came up missing, 74 of them, the Color statics and TypeRegistry among them: OTIO_API_TYPE is empty on Windows, where only the per-member OTIO_API carries the declspec. Those members are marked. The three find_children templates lose OTIO_API in turn, a template defined in a header being something that cannot be imported, and two source files that define exported functions without including the header that marks them are given the include. No change to what either library exports on macOS or Linux: the symbol tables of a shared build are identical before and after. Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
SerializableObject's destructor, its Reader's any overload and type check, and its Writer's int64_t overload had no OTIO_API on them. A build that hides its symbols by default, which main does since AcademySoftwareFoundation#2041, leaves them out of the library and upgrade_downgrade_example cannot be linked. Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
darbyjohnston
force-pushed
the
windows-shared-exports
branch
from
September 22, 2026 18:01
eaa46f8 to
98b84aa
Compare
darbyjohnston
merged commit Sep 22, 2026
64bb3cd
into
AcademySoftwareFoundation:main
51 checks passed
darbyjohnston
added a commit
that referenced
this pull request
Sep 22, 2026
* Put Windows executables and their DLLs in one build directory Nothing set an output directory, so on a multi-config generator the test and example executables land in build/tests/<config> while the shared libraries land in build/src/<lib>/<config>. Windows looks for a DLL next to the executable or on PATH, neither of which covers that, so the tests cannot start from the build tree when OTIO_SHARED_LIBS is ON. Windows executables and DLLs now go to build/bin. The other platforms resolve a shared library through its install name or RPATH and are left alone, as are static builds, where an archive is not a runtime artifact. Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com> * Build and test shared libraries in CI OTIO_SHARED_LIBS defaults to ON, but every build in the repository turned it off: setup.py and the only C++ job. The default configuration was therefore never built or tested, and it is the only one where the export annotations mean anything, as #2039 showed. The C++ job gains a shared dimension, six legs rather than three. Code coverage stays on the static Linux leg alone rather than being collected twice. Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com> * Set the coverage flag from the matrix rather than an expression The ternary form of && and || is easy to misread, and it is only correct while both of its values are truthy. The matrix carries the flag instead. Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com> --------- Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has various fixes for the API exports:
Assisted-by: Claude:claude-opus-5 [debugging]