Draft: Fix null pointer dereferences after dynamic_cast#2017
Open
jminor wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
Open
Draft: Fix null pointer dereferences after dynamic_cast#2017jminor wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
jminor wants to merge 3 commits intoAcademySoftwareFoundation:mainfrom
Conversation
Assisted-by: Claude Code / Opus 4.7
Assisted-by: Claude Code / Opus 4.7 Note: Claude Code Opus 4.6 was used to find this bug, and Opus 4.7 was used to fix it.
specific line numbers.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
==========================================
- Coverage 85.14% 85.01% -0.14%
==========================================
Files 181 181
Lines 12780 12800 +20
Branches 1206 1214 +8
==========================================
Hits 10882 10882
- Misses 1715 1735 +20
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain invalid OTIO object graphs with cycles may cause crashes due to code that assumes a dynamic_cast always returns a valid object. This PR introduces tests which demonstrate the issue and a fix to prevent the crash in those cases.
Note that the discovery of this issue and portions of the test code and fix were assisted by Claude Code Opus 4.6 and Opus 4.7. Since OTIO's policy on LLM use is still in discussion, this PR is marked as a draft.