fix: SG-44617: Build imgui with custom RV_DEPS_BASE_DIR - #1367
Open
paulbarton90 wants to merge 1 commit into
Open
fix: SG-44617: Build imgui with custom RV_DEPS_BASE_DIR#1367paulbarton90 wants to merge 1 commit into
paulbarton90 wants to merge 1 commit into
Conversation
paulbarton90
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
July 27, 2026 17:25
With the current build system if you specify a custom RV_DEPS_BASE_DIR it failed to build imgui correctly. This patch resolves this by using the standard arguments as found in `rv_create_std_deps_vars.cmake`. Signed-off-by: Paul Barton <28630076+paulbarton90@users.noreply.github.com>
paulbarton90
force-pushed
the
imgui_build_patch
branch
from
July 27, 2026 17:26
0182b74 to
ee65ec5
Compare
eloisebrosseau
changed the title
eloisebrosseau
added
community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
None
Summarize your change.
Updated items in
imgui.cmaketo use the items created via the macroRV_CREATE_STANDARD_DEPS_VARIABLES.Describe the reason for the change.
Building OpenRV with a custom
RV_DEPS_BASE_DIRset caused the configuration step forRV_DEPS_IMGUIto fail with unable to find the source directory.Describe what you have tested and on which operating system.
Tested on CY2024 on Rocky Linux 9.7.
Add a list of changes, and note any that might need special attention during the review.
The configure command used to configure the OpenRV build was:
If possible, provide screenshots.
N/A