Draft: SG-44542: source setup modernization - #1356
Open
herronelou wants to merge 9 commits into
Open
Conversation
Replaced print statements with logging for better control over output levels and formatting. Signed-off-by: Erwan Leroy <herronelou@gmail.com>
Signed-off-by: Erwan Leroy <herronelou@gmail.com>
Refactor OCIO management functions to use functools.partial for better compatibility and maintainability. Deprecate old public API methods while preserving functionality. Signed-off-by: Erwan Leroy <herronelou@gmail.com>
This was done with assistance from Google Gemini Signed-off-by: Erwan Leroy <herronelou@gmail.com>
This is meant as an amendment to the last commit Signed-off-by: Erwan Leroy <herronelou@gmail.com>
Refactored addPath function to remove redundant returns and improve clarity. Updated method overriding to use getattr for better attribute handling. Signed-off-by: Erwan Leroy <herronelou@gmail.com>
Signed-off-by: Erwan Leroy <herronelou@gmail.com>
Signed-off-by: Erwan Leroy <herronelou@gmail.com>
Signed-off-by: Erwan Leroy <herronelou@gmail.com>
herronelou
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
July 21, 2026 11:16
herronelou
commented
Jul 21, 2026
| return commands.UncheckedMenuState | ||
|
|
||
| return F | ||
| def isOCIOManaged(nodeType: str) -> Callable[[], int]: |
Contributor
Author
There was a problem hiding this comment.
I’d have removed these as I don’t think anyone should really import from this file, but decided to maintain “public API” for this PR
eloisebrosseau
changed the title
eloisebrosseau
added
community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summarize your change.
In this MR I do a pass of trying to modernize ocio_source_setup for python 3.10+, attempting to maintain compatibility, logic and signatures from previous implementation.
I would have liked to change a bit more but figured I’d limit the scope for this MR to mostly stylistic changes.
I made separate commits for each change I made so we could pick and choose what would make sense to use or not.
Describe the reason for the change.
This module used some non-conventional python patterns, making the code difficult to read and follow. Rather than an extensive rewrite, I figured cleaning up the odd patterns and adding docstrings could be a step in the right direction.
Describe what you have tested and on which operating system.
This draft is currently barely tested, and some of the commits were done with assistance from Gemini. Drafting this from Siggraph after a conversation with @rogernelson