fix: SG-43708: Prevent preloader threads from running in rvio - #1305
Merged
eloisebrosseau merged 1 commit intoJul 31, 2026
Conversation
startPreloadingMedia() starts background threads that preload media from disk. These threads are only safe in interactive RV, where session loading is intentionally deferred (delaySessionLoading=1). In rvio, session loading is synchronous (delaySessionLoading=0) and the background threads race with it, causing heap corruption and SIGABRT. commit 512d418 added this preload call during .rv session restore but gated it only on progressiveSourceLoading, inadvertently enabling it in rvio. The fix adds delaySessionLoading to the condition so rvio never starts preloader threads. Signed-off-by: Mark Reid <markreid@netflixanimation.com>
markreidvfx
requested review from
bernie-laberge,
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
June 10, 2026 06:21
bernie-laberge
changed the title
bernie-laberge
added
PR: Acknowledged
eloisebrosseau
added
PR: Planned_P1
eloisebrosseau
approved these changes
Jul 13, 2026
eloisebrosseau
added
PR: In Testing
bernie-laberge
approved these changes
Jul 31, 2026
bernie-laberge
left a comment
bernie-laberge
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @markreidvfx !
eloisebrosseau
merged commit Jul 31, 2026
82c53b8
into
AcademySoftwareFoundation:main
17 checks passed
eloisebrosseau
removed
the
PR: In Testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issues
N/A
Summarize your change.
Prevent
startPreloadingMedia()background threads from running in rvio/batch mode where they race with synchronous session loading and cause heap corruption.Describe the reason for the change.
startPreloadingMedia()starts background threads that preload media from disk. These are only safe in interactive RV, where session loading is deferred (delaySessionLoading=1). In rvio, session loading is synchronous (delaySessionLoading=0) and the preloader threads race with it, causing non-deterministic heap corruption and SIGABRT. The preload call was added in commit512d4182but only gated onprogressiveSourceLoading, inadvertently enabling it in rvio. The fix addsdelaySessionLoadingto the condition.Describe what you have tested and on which operating system.
Tested on Rocky Linux 9.
Add a list of changes, and note any that might need special attention during the review.
RvSession.cpp: AdddelaySessionLoadingcheck to the preload condition so rvio/batch mode never starts background preloader threads.If possible, provide screenshots.
N/A