fix(build): internalize fmt/args.h to avoid mixing fmt versions - #5486
Merged
Merged
Conversation
PR 5481 added `#include <fmt/args.h>` to expressions.cpp, the only raw `<fmt/...>` include in the tree. Everything else includes `<OpenImageIO/detail/fmt/...>`, the copies internalized into the build tree, and args.h was not among the internalized headers. This fmt header needs to do the same in order to avoid version mismatches. Curiously, it was only on the "wheel" workflow, and on Mac, where it happened to fail in CI. That's why we didn't notice when 5481 was in review -- not intentionally touching python, it did not trigger the wheel workflow. Assisted-by: Claude Code / Claude Opus 5 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
Pre-emptively merging without review because it fixes CI that is broken without it. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 21, 2026
…emySoftwareFoundation#5486) PR AcademySoftwareFoundation#5481 added `#include <fmt/args.h>` to expressions.cpp, the only raw `<fmt/...>` include in the tree. Everything else includes `<OpenImageIO/detail/fmt/...>`, the copies internalized into the build tree, and args.h was not among the internalized headers. This args.h header also needs to do the same in order to avoid version mismatches. Curiously, it was only on the "wheel" workflow, and on Mac, where it happened to fail in CI. That's why we didn't notice when AcademySoftwareFoundation#5481 was in review -- not intentionally touching python, it did not trigger the wheel workflow. Assisted-by: Claude Code / Claude Opus 5 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #5481 added
#include <fmt/args.h>to expressions.cpp, the only raw<fmt/...>include in the tree. Everything else includes<OpenImageIO/detail/fmt/...>, the copies internalized into the build tree, and args.h was not among the internalized headers.This args.h header also needs to do the same in order to avoid version mismatches.
Curiously, it was only on the "wheel" workflow, and on Mac, where it happened to fail in CI. That's why we didn't notice when #5481 was in review -- not intentionally touching python, it did not trigger the wheel workflow.
Assisted-by: Claude Code / Claude Opus 5