fix(dpx): ignore end-of-line padding when writing - #5472
Merged
Merged
Conversation
The libdpx writer strides the caller's pixel buffer by the declared end-of-line padding, but our scanline buffer is always tightly packed. Since the value was passed through from an input file's header, a crafted DPX made the writer read far past the end of the buffer during dpx-to-dpx conversion. Declare zero padding instead; we can never supply a padded buffer, so the pass-through could not have produced a correct file anyway. Fixes 1861 Assisted-by: Claude Code / Claude Opus 5 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
Comments? |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Preserve end-of-image padding while zeroing only end-of-line padding.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Fixes a DPX writer buffer over-read by ignoring inherited end-of-line padding for tightly packed buffers.
Changes:
- Adds regression coverage for padded metadata.
- Updates expected DPX output metadata.
- Requires preserving end-of-image padding while forcing only end-of-line padding to zero.
| File | Summary |
|---|---|
testsuite/dpx/run.py |
Adds regression coverage for nonzero padding attributes. |
testsuite/dpx/ref/out.txt |
Updates expected output metadata. |
src/dpx.imageio/dpxoutput.cpp |
Prevents unsafe end-of-line strides; preserve the documented end-of-image padding attribute. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
No comments for a week -> merging |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 21, 2026
…ndation#5472) The libdpx writer strides the caller's pixel buffer by the declared end-of-line padding, but our scanline buffer is always tightly packed. Since the value was passed through from an input file's header, a crafted DPX made the writer read far past the end of the buffer during dpx-to-dpx conversion. Declare zero padding instead. Fixes AcademySoftwareFoundation#1861 Assisted-by: Claude Code / Claude Opus 5 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libdpx writer strides the caller's pixel buffer by the declared end-of-line padding, but our scanline buffer is always tightly packed. Since the value was passed through from an input file's header, a crafted DPX made the writer read far past the end of the buffer during dpx-to-dpx conversion. Declare zero padding instead.
Fixes #1861
Assisted-by: Claude Code / Claude Opus 5