feat(oiiotool): Add thumbnail get/set commands and fix TGA thumbnail I/O#5236
Open
jinhgkim wants to merge 8 commits into
Open
feat(oiiotool): Add thumbnail get/set commands and fix TGA thumbnail I/O#5236jinhgkim wants to merge 8 commits into
jinhgkim wants to merge 8 commits into
Conversation
Assisted-by: Claude Code / opus-4.8 Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
Assisted-by: Claude Code / opus-4.8 Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
Assisted-by: Claude Code / opus-4.8 Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
Encode the embedded thumbnail the same way as the main image: bottom-up scanlines, deassociated alpha, and BGR(A) channel order. The original implementation rather dumped the raw in-memory buffer, which left the thumbnail flipped, R/B-swapped, and premultiplied. Also clamp an oversized thumbnail to 255 rather than 256: each postage-stamp dimension is a single byte, so 256 wrapped to 0 and the thumbnail was silently dropped on read. Assisted-by: Claude Code / opus-4.8 Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
TGA stores unassociated alpha, but OIIO keeps it associated in memory. `readimg()` converts on read; `get_thumbnail()` did not, so RGBA thumbnails came back too bright. Apply the same `associateAlpha()` conversion to the thumbnail. get_thumbnail() is moved below associateAlpha() so it can call it without a forward declaration. Assisted-by: Claude Code / opus-4.8 Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
Assisted-by: Claude Code / opus-4.8 Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
54e6a14 to
2b002d9
Compare
Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
2b002d9 to
c589b11
Compare
Author
|
During the CI run, a TGA thumbnail test failed because I added Let me know what you think. Also, fyi, I have broken down the commits into logical steps with some details in the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
oiiotoolcommands to extract and attach embedded thumbnails, and fixes TGA postage-stamp read/write bugs they exposed. This PR adresses #4889.Note that thumbnail support is uneven across formats:
get_thumbnailis implemented for PSD, camera RAW, and TGA, butset_thumbnailonly for TGA. So you can read thumbnails from several formats, yet TGA is the only format that writes an embedded thumbnail today. e.g.,input.exr ... --set-thumbnail -o out.exrsilently produces an EXR with no embedded thumbnail.Features:
oiiotool: add--get-thumbnailoiiotool: add-i:get_thumbnail=1oiiotool: add--set-thumbnailFixes:
write: encode thumbnail like the main image (bottom-up, deassociated alpha, BGR(A))read: applyassociateAlpha()Assisted-by: Claude Code / opus-4.8
Tests
New tests in
oiiotool-get-thumbnail,oiiotool-set-thumbnail,imagebuf_testChecklist:
and if I used AI coding assistants, I have an
Assisted-by: TOOL / MODELline in the pull request description above.
behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.