Option to use compiled fmt library#5231
Open
ssh4net wants to merge 1 commit into
Open
Conversation
Introduce OIIO_USE_COMPILED_FMT CMake option to allow linking against a compiled fmt (fmt::fmt) instead of the header-only variant. Update externalpackages.cmake to expose the option, select the appropriate fmt target and include dir, and pass the value into generated headers via oiioversion.h. Adjust Config.cmake.in to avoid forcing find_dependency(fmt) when header-only behavior is overridden. Modify detail/fmt.h to skip defining FMT_HEADER_ONLY when compiled fmt is used, and update libutil CMakeLists and ustring.cpp to link/use the compiled fmt target and use fmt::runtime for dynamic format strings. Signed-off-by: Vlad <shaamaan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OpenImageIO uses the fmt library, but spdlog is also quite common and uses the fmt library. This fix should allow to use precompiled fmt library in both spdlog and oiio if they are used in same project.
Added
OIIO_USE_COMPILED_FMTCMake option to allow linking against a compiled fmt (fmt::fmt) instead of the header-only variant.Update externalpackages.cmake to expose the option, select the appropriate fmt target and include dir, and pass the value into generated headers via oiioversion.h.
Adjust Config.cmake.in to avoid forcing find_dependency(fmt) when header-only behavior is overridden. Modify detail/fmt.h to skip defining
FMT_HEADER_ONLYwhen compiled fmt is used, and update libutil CMakeLists and ustring.cpp to link/use the compiled fmt target and use fmt::runtime for dynamic format strings.Checklist:
and if I used AI coding assistants, I have an
Assisted-by: Codex 5.5 ExtraHigh.behavior.
PR, by pushing the changes to my fork and seeing that the automated CI
passed there. (Exceptions: If most tests pass and you can't figure out why
the remaining ones fail, it's ok to submit the PR and ask for help. Or if
any failures seem entirely unrelated to your change; sometimes things break
on the GitHub runners.)
fixed any problems reported by the clang-format CI test.
corresponding Python bindings. If altering ImageBufAlgo functions, I also
exposed the new functionality as oiiotool options.