Skip to content

Reject aligned attribute on bit fields in struct types #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xavierleroy wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Reject aligned attribute on bit fields in struct types #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cparser/Cutil.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,8 @@ let sizeof_layout_struct env members ma =
(record_field m.fld_name pos :: accu)
rem
| Some width ->
(* bit fields must be naturally aligned *)
assert (alignas_attribute (attributes_of_type env m.fld_typ) = 0);
(* curr = beginning of storage unit, in bits
next = one past end of storage unit, in bits *)
let curr = pos / (a * 8) * (a * 8) in
Expand Down
2 changes: 1 addition & 1 deletion cparser/Elab.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,7 @@ and elab_field_group env = function
error loc
"the type of bit-field '%a' must be an integer type no bigger than 'int'" pp_field id;
None,env
end else if has_std_alignas env' ty then begin
end else if alignas_attribute (attributes_of_type env' ty) > 0 then begin
error loc "alignment specified for bit-field '%a'" pp_field id;
None, env
end else begin
Expand Down
Loading