Veto beam pads#264
Open
RealAurio wants to merge 2 commits intoATTPC:developfrom
Open
Conversation
… prevented the inhibited pads from being unpacked. Added mappings of RCNP and e23031 experiments, with their respective beam pads mappings.
… the beam region list, to check if it makes sense. Changed the check on the test to make sure it tests for kXTalk. Removed the 0,1,2,3,4 line from the beam pads list, since padID=4 does not actually belong to the beam region.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a way to prevent the beam region pads data from being unpacked, since it may produce artifact AtHits due to cross talk. We actually saw this during one of the RCNP experiments.
In the following image, you can see that there are a few hits inside the beam region where there are no pads.
This also changes the unpacker logic a little bit, since inhibited pads would be unpacked either way.