Fix installation process and library path for exported target - #12
Open
KunoVonHagen wants to merge 4 commits into
Open
Fix installation process and library path for exported target#12KunoVonHagen wants to merge 4 commits into
KunoVonHagen wants to merge 4 commits into
Conversation
Collaborator
Author
|
Even though this pull request fixed downstream issues in the C implementation. C++ consumers still experienced issues. The latest commit fixes that. Please re-check the additional changes. |
stefanDeveloper
approved these changes
Aug 20, 2026
stefanDeveloper
left a comment
stefanDeveloper
left a comment
Member
There was a problem hiding this comment.
Looks good from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the C++ client build and packaging workflow to streamline the release process and improve CMake installation handling. The main changes focus on using CMake's install mechanism for packaging, updating workflow steps, and improving installation path handling.
Build and packaging workflow improvements:
cmake --installto install build artifacts into the package directory, replacing manual copy commands, and packages the installed files directly. This simplifies the release process and ensures consistency between local and CI builds.CMake configuration enhancements:
include(GNUInstallDirs)at the top ofCMakeLists.txtto ensure standard installation directories are used.target_link_librariesinstall interface to use$<INSTALL_PREFIX>for the static library path, ensuring correct resolution of the install location during package installation.include(GNUInstallDirs)from the installation section, as it is now included at the top of the file.