Move variable/identifier family out-of-line into MLIRGenVariables.cpp (§1)#227
Merged
Conversation
… (review doc 1) 20 methods (variable registration incl. this-context and declaration, array/object binding patterns with sub-paths and spread, declaration name/item processing, VariableDeclaration/List, parameter bindings, and the identifier/type/namespace resolution family) move from MLIRGenImpl.h into a new MLIRGenVariables.cpp TU; header keeps declarations with defaults. 1223 lines out of the header (11902 -> 10679). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
§1 TU split — same pattern as #217–#226.
20 methods move from
MLIRGenImpl.hinto a newMLIRGenVariables.cppTU: variable registration (registerVariable,registerVariableInThisContext,registerVariableDeclaration), the array/object binding-pattern family (incl. sub-paths and spread),processDeclarationName/processDeclaration,mlirGen(VariableDeclaration)/mlirGen(VariableDeclarationList),mlirGenParameterObjectOrArrayBinding, and the resolution family (resolveIdentifierAsVariable,resolveFunctionNameInNamespace,resolveTypeByNameInNamespace,resolveTypeByName,resolveIdentifierInNamespace,resolveFullNameIdentifier,resolveIdentifier).Test plan
🤖 Generated with Claude Code