Move statement family out-of-line into MLIRGenStatements.cpp (§1)#221
Merged
Conversation
- Added methods for generating MLIR code for various statement types including blocks, expressions, and control flow statements (if, while, for, etc.). - Introduced handling for return, break, continue, and throw statements. - Implemented support for labeled statements and switch cases. - Enhanced error handling and state management during code generation. - Integrated debug information generation for MLIR. - Established a clear structure for processing different statement kinds and their corresponding MLIR operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the §1 TU split (
docs/MLIRGen-refactoring-review.md), same pattern as #217–#220.21 statement-level methods move from
MLIRGenImpl.hinto a newMLIRGenStatements.cppTU, with declarations left in the header:mlirGenBody,clearState, theNodeArray<Statement>/ts::Block/Statementdispatchers, and theExpressionStatement,VariableStatement,ReturnStatement,IfStatement,DoStatement,WhileStatement,ForStatement,ForInStatement,ForOfStatement,LabeledStatement,DebuggerStatement,ContinueStatement,BreakStatement,SwitchStatement,ThrowStatement,TryStatementgenerators.ts::Blockdispatcher'sskipStatements = 0) stays on the declaration and is stripped from the out-of-line definitionRemaining §1 families after this: expressions, functions, classes.
Test plan
🤖 Generated with Claude Code