Send HTML and PDF reports in Slack#5
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Slack “final response” flow to attach the generated HTML report and PDF report directly into the originating Slack thread, while also adding a delivery note to the rendered Slack summary so users understand what was attached (or what failed).
Changes:
- Add
reportDeliveryNotetorenderBlocksso Slack summaries can include an attachment/upload status note. - Update Slack event handling to attempt
filesUploadV2with the HTML + PDF outputs and fall back to a concise text summary if upload fails. - Extend pipeline hardening coverage to assert the new delivery note is included in the rendered summary.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/pipeline-hardening.test.ts | Adds an assertion that the new report delivery note appears in the rendered Slack summary. |
| src/slack/render.ts | Extends summary rendering to include a configurable delivery/upload note line. |
| src/slack/events.ts | Adds HTML/PDF upload via Slack filesUploadV2, builds attached vs fallback summaries, and posts fallback summary on upload failure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+165
to
+170
| file_uploads: files.map((file) => ({ | ||
| file: file.filePath, | ||
| filename: file.fileName, | ||
| title: file.title, | ||
| filetype: file.filetype, | ||
| })), |
Comment on lines
+421
to
+425
| htmlReportFile = { | ||
| filePath: saved.filePath, | ||
| fileName: saved.fileName, | ||
| title: "Interactive HTML report", | ||
| filetype: "html", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uploads the generated interactive HTML report and formal PDF report together in the final Slack thread response. Preserves the existing report and evidence links when configured, and posts a concise fallback summary if report generation or Slack upload fails. Adds renderer coverage for the new attachment delivery note.