-
Notifications
You must be signed in to change notification settings - Fork 0
Fix docs-only gate for binary files #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from hyrule_engineering_loop.gate_runner import run_gate_commands, select_gate_commands_for_mutations | ||
|
|
||
|
|
||
| def test_docs_gate_reads_only_mutated_text_paths(tmp_path) -> None: | ||
| (tmp_path / "docs").mkdir() | ||
| (tmp_path / "docs" / "note.md").write_text("hello\n", encoding="utf-8") | ||
| (tmp_path / "binary.bin").write_bytes(b"\xb8\x00not utf8") | ||
|
|
||
| commands = select_gate_commands_for_mutations(["engineering-loop:docs/note.md"]) | ||
| results, errors = run_gate_commands(commands, cwd=tmp_path) | ||
|
|
||
| assert errors == [] | ||
| assert results[0]["returncode"] == 0 | ||
|
|
||
|
|
||
| def test_docs_gate_reports_non_utf8_mutated_file(tmp_path) -> None: | ||
| (tmp_path / "docs").mkdir() | ||
| (tmp_path / "docs" / "note.md").write_bytes(b"\xb8\x00not utf8") | ||
|
|
||
| commands = select_gate_commands_for_mutations(["docs/note.md"]) | ||
| results, errors = run_gate_commands(commands, cwd=tmp_path) | ||
|
|
||
| assert results[0]["returncode"] == 1 | ||
| assert errors | ||
| assert "UnicodeDecodeError" in errors[0]["stderr"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a changed doc path itself contains a colon (valid in git paths on POSIX, e.g.
docs/foo:bar.mdfrom backendchanged_paths), the normalization above treats it like arepo:pathkey and this new targeted list serializes onlybar.md. The generated gate then seesbar.mdmissing and continues, so the actual mutated doc is never UTF-8 checked; a non-UTF-8docs/foo:bar.mdnow passes even though the previousrglobscan failed. Please only strip repo prefixes for repo-scoped mutation keys, not arbitrary colon-containing paths.Useful? React with 👍 / 👎.