Za/openmetadata - #734
Open
amrc-za wants to merge 14 commits into
Open
Conversation
removed the custom one because opensearch helm chart already provides service
… new and flatten docker images
djnewbould
requested changes
Aug 27, 2026
djnewbould
left a comment
djnewbould
left a comment
Contributor
There was a problem hiding this comment.
It all looks good! I've just left a couple of small comments.
Contributor
There was a problem hiding this comment.
Should this be wrapped with {{ if .Values.openmetadata.enabled }}?
I think they're missing namespace: {{ .Release.Namespace }} too
Comment on lines
+13
to
+24
| apiVersion: v1 | ||
| kind: PersistentVolumeClaim | ||
| metadata: | ||
| name: acs-dags | ||
| spec: | ||
| accessModes: | ||
| - ReadWriteOnce | ||
| resources: | ||
| requests: | ||
| storage: 1Gi | ||
|
|
||
| --- |
Contributor
There was a problem hiding this comment.
Is this one redundant? I can't see where its used anywhere
Comment on lines
+21
to
+27
| # --- | ||
| # service: !u UUIDs.Service.Authentication | ||
| # version: 2 | ||
| # grants: | ||
| # !u Openmetadata.Requirement.ServiceRole: | ||
| # !u UUIDs.Permission.Directory.AdvertiseService: | ||
| # !u Openmetadata.Service.Openmetadata: false |
Contributor
There was a problem hiding this comment.
Does it need this grant or is it fine without it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds OpenMetadata as a new optional ACS service, deployed via the upstream openmetadata and openmetadata-dependencies Helm charts (v1.13.3).
The upstream images for OpenMetadata's server, its ingestion/Airflow component, and OpenSearch (used as OpenMetadata's search backend) all bundle outdated log4j-core/log4j-api jars with known CVEs. Rather than wait on upstream, we build three patched images that swap in log4j 2.26.1 and use them in place of the stock images.