Skip to content

Za/files - fixed file write abortion by request timeout - #733

Open
amrc-za wants to merge 17 commits into
mainfrom
za/files
Open

Za/files - fixed file write abortion by request timeout#733
amrc-za wants to merge 17 commits into
mainfrom
za/files

Conversation

@amrc-za

@amrc-za amrc-za commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Fixed node's default 5 minute request timeout aborting file write for large files:

  • lib/js-service-api/lib/webapi.js — added an opt-in request_timeout option.
  • acs-files/bin/api.js — passes request_timeout
  • deploy/templates/files/files.yaml — added a REQUEST_TIMEOUT env var
  • deploy/values.yaml — added files.requestTimeout: 0 (0 disables Node's request timeout entirely, so an upload can take as long as it needs)

@amrc-za
amrc-za requested a review from djnewbould August 21, 2026 12:32

@djnewbould djnewbould left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the service api all look good. I can't merge it before the open metadata stuff is merged. It might be worth basing the last three commits off of main so we can merge it sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants