Skip to content

feat: add ingest_key parameter as alias for write_key#8

Merged
oscarvalenzuelab merged 1 commit intomainfrom
feat/ingest-key-alias
Apr 14, 2026
Merged

feat: add ingest_key parameter as alias for write_key#8
oscarvalenzuelab merged 1 commit intomainfrom
feat/ingest-key-alias

Conversation

@oscarvalenzuelab
Copy link
Copy Markdown
Contributor

Summary

  • Add ingest_key parameter (preferred over deprecated write_key)
  • Add OPS_INGEST_KEY env var (preferred over OPS_WRITE_KEY)
  • Maintains full backwards compatibility

Changes

client.py

  • Added ingest_key parameter to __init__
  • Priority: ingest_key > write_key > OPS_INGEST_KEY > OPS_WRITE_KEY

tests/test_client.py

  • Added tests for ingest_key parameter
  • Added tests for OPS_INGEST_KEY env var
  • Added tests for precedence

Test plan

  • All existing tests pass
  • New tests for ingest_key parameter pass
  • New tests for OPS_INGEST_KEY env var pass

Closes #7

- Add ingest_key parameter (preferred over deprecated write_key)
- Add OPS_INGEST_KEY env var (preferred over OPS_WRITE_KEY)
- Maintains full backwards compatibility
- Add tests for new parameter and env var

Closes #7
@cla-bot cla-bot bot added the cla-signed label Apr 14, 2026
@oscarvalenzuelab oscarvalenzuelab merged commit 36ea382 into main Apr 14, 2026
5 checks passed
@oscarvalenzuelab oscarvalenzuelab deleted the feat/ingest-key-alias branch April 14, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support ingest_key parameter as alias for write_key

1 participant