Fix snapshot restore for abstract shapes and memory kind - #4879
Merged
Conversation
sadikneipp
requested review from
A9isha,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
huytransformer,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
vipannalla and
xibinliu
as code owners
August 13, 2026 21:11
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the pathways-utils dependency version and modifies the restore_original_shardings function in train_utils.py to compare sharding and memory_kind attributes on leaves. The review feedback points out a critical bug where jax.device_put could be called on a jax.ShapeDtypeStruct (which has a sharding attribute but is not a valid array-like object), resulting in a TypeError. It also notes that the subsequent elif block becomes redundant, and provides a code suggestion to resolve both issues.
sadikneipp
force-pushed
the
ksadi/snapshot-scale-fix
branch
3 times, most recently
from
August 14, 2026 18:01
0c8abd1 to
e16716c
Compare
sadikneipp
force-pushed
the
ksadi/snapshot-scale-fix
branch
from
August 14, 2026 18:04
e16716c to
b7b4dd4
Compare
sadikneipp
merged commit Aug 14, 2026
193b648
into
abhinavsing/snapshot-scale
16 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.