Fix logical sharding resolution in NNX#4205
Open
xibinliu wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
a9aedd5 to
e044d17
Compare
In pure NNX training runs, model variables retrieve physical PartitionSpecs via `get_nnx_named_sharding_with_scan_axis` in `maxtext_utils.py`. Previously, this helper used Flax core SPMD's `from_sharding_rules` to map logical names to physical axes. However, `from_sharding_rules` resolves rules by converting the rules list into a dictionary (last-write-wins). This caused fallback rules sharing the same logical name (e.g. 'embed') to overwrite preceding specific rules, dropping essential axes like `fsdp_transpose` and leading to unsharded parameter percentage assertion errors. Additionally, resolving specifications independently for each dimension without tracking assigned axes could bind a single physical axis (like `fsdp_transpose`) to multiple positional dimensions of a tensor, causing `DuplicateSpecError`. To fix this: 1. Replaced `from_sharding_rules` with a Rules-first resolution loop that matches rules sequentially (first-match-wins), matching Flax Linen's mapping behavior. 2. Implemented an `assigned_axes` tracker within the loop to ensure physical mesh axes are bound to at most one dimension per tensor. 3. Added unit tests covering sequential matching (first-match-wins) and duplicate physical axis prevention during resolution.
e044d17 to
0730724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In pure NNX training runs, model variables retrieve physical PartitionSpecs via
get_nnx_named_sharding_with_scan_axisinmaxtext_utils.py. Previously, this helper used Flax core SPMD'sfrom_sharding_rulesto map logical names to physical axes. However,from_sharding_rulesresolves rules by converting the rules list into a dictionary (last-write-wins). This caused fallback rules sharing the same logical name (e.g. 'embed') to overwrite preceding specific rules, dropping essential axes likefsdp_transposeand leading to unsharded parameter percentage assertion errors.Additionally, resolving specifications independently for each dimension without tracking assigned axes could bind a single physical axis (like
fsdp_transpose) to multiple positional dimensions of a tensor, causingDuplicateSpecError.To fix this:
from_sharding_ruleswith a Rules-first resolution loop that matches rules sequentially (first-match-wins), matching Flax Linen's mapping behavior.assigned_axestracker within the loop to ensure physical mesh axes are bound to at most one dimension per tensor.Tests
Log with Gemma3-12B (2x v6e-256)
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.