[ROCm]: test: update HLO references after tmem optimizations (PR4)#4194
Open
cj401-amd wants to merge 5 commits into
Open
[ROCm]: test: update HLO references after tmem optimizations (PR4)#4194cj401-amd wants to merge 5 commits into
cj401-amd wants to merge 5 commits into
Conversation
cj401-amd
requested review from
A9isha,
NicoGrande,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
…o yml can reference it
…ipeline_save_decoder_layer_input flag
… default, skip_trivial_specs
…r tmem optimizations
cj401-amd
force-pushed
the
cj/tmem-fixes-clean-4-hlo-references
branch
from
7e7d36b to
ba88323
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update golden HLO reference files to reflect the changed XLA output after the tmem
optimizations in PRs 1–3. The HLO structure changes due to:
ppermutecollectives (replaced withslice/pad)Updated files:
tests/utils/reference_hlo_deepseek3.txttests/utils/reference_hlo_llama3_8b.txttests/utils/reference_hlo_qwen3_1.7b.txtTest plan
python3 -m pytest tests/integration/hlo_diff_test.py -v