Fix post-training Docker build for new vllm commit#4184
Open
khatwanimohit wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
GCC version: Upgrades TPU Dockerfile base image from
python:3.12-slim-bullseye(GCC 10.2.1) to
python:3.12-slim-bookworm(GCC 12.2.0). The new vllm commit(
a30addc7) introduced a CMake check requiring GCC ≥ 11.3 for C++20 supportvllm PR #44923.
Missing fastapi extras: Restores
fastapi>=0.136.3,fastapi-cli,fastapi-cloud-cli, andfastarin the generated requirements. The previousgenerate_requirements.shrun resolved fastapi to0.115.0(lowest satisfyingvllm>=0.115.0+tpu-inference<0.137.0), which predates thefastar/fastapi-cliextras added in
0.136.x. Also pinsfastapi[standard]>=0.136.3andfastarinbase requirements to prevent future regenerations from dropping these.
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
build_maxtext_docker_image WORKFLOW=post-trainingcompletes successfullyChecklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.