Skip to content

Respect enable_tensorboard=False#3806

Merged
copybara-service[bot] merged 1 commit intomainfrom
xfgu-onduty
May 4, 2026
Merged

Respect enable_tensorboard=False#3806
copybara-service[bot] merged 1 commit intomainfrom
xfgu-onduty

Conversation

@xuefgu
Copy link
Copy Markdown
Collaborator

@xuefgu xuefgu commented May 4, 2026

Description

FIXES: #3790

Tests

Manual

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@xuefgu xuefgu marked this pull request as ready for review May 4, 2026 20:24
@xuefgu xuefgu force-pushed the xfgu-onduty branch 2 times, most recently from 6f3e340 to 4bd2a8a Compare May 4, 2026 21:41
@copybara-service copybara-service Bot merged commit f6fca0f into main May 4, 2026
41 of 44 checks passed
@copybara-service copybara-service Bot deleted the xfgu-onduty branch May 4, 2026 23:36
@xuefgu xuefgu mentioned this pull request May 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SurbhiJainUSC SurbhiJainUSC SurbhiJainUSC approved these changes

@bvandermoon bvandermoon bvandermoon approved these changes

@abhinavclemson abhinavclemson Awaiting requested review from abhinavclemson abhinavclemson is a code owner

@gobbleturk gobbleturk Awaiting requested review from gobbleturk gobbleturk is a code owner

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

@RissyRan RissyRan Awaiting requested review from RissyRan RissyRan is a code owner

@richjames0 richjames0 Awaiting requested review from richjames0 richjames0 is a code owner

@gagika gagika Awaiting requested review from gagika gagika is a code owner

@shralex shralex Awaiting requested review from shralex shralex is a code owner

@hengtaoguo hengtaoguo Awaiting requested review from hengtaoguo hengtaoguo is a code owner

@A9isha A9isha Awaiting requested review from A9isha A9isha is a code owner

@aireenmei aireenmei Awaiting requested review from aireenmei aireenmei is a code owner

@NuojCheng NuojCheng Awaiting requested review from NuojCheng NuojCheng is a code owner

@jiangjy1982 jiangjy1982 Awaiting requested review from jiangjy1982 jiangjy1982 is a code owner

@suexu1025 suexu1025 Awaiting requested review from suexu1025 suexu1025 is a code owner

@NicoGrande NicoGrande Awaiting requested review from NicoGrande NicoGrande is a code owner

@jesselu-google jesselu-google Awaiting requested review from jesselu-google jesselu-google is a code owner

@dipannita08 dipannita08 Awaiting requested review from dipannita08 dipannita08 is a code owner

@igorts-git igorts-git Awaiting requested review from igorts-git igorts-git is a code owner

@mitalisi mitalisi Awaiting requested review from mitalisi

@gpolovets1 gpolovets1 Awaiting requested review from gpolovets1

@mailvijayasingh mailvijayasingh Awaiting requested review from mailvijayasingh

@jrplatin jrplatin Awaiting requested review from jrplatin

@patemotter patemotter Awaiting requested review from patemotter

@Lumosis Lumosis Awaiting requested review from Lumosis

Assignees

No one assigned

Labels

pull ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fresh runs can save a checkpoint at step 0 and tensorboard writes unconditionally

3 participants

@xuefgu @SurbhiJainUSC @bvandermoon