Skip to content

fix: federated OIDC login inside azure/cli container#145

Merged
jschoedl merged 1 commit into
mainfrom
fix/azure-oidc-in-container
Jul 19, 2026
Merged

fix: federated OIDC login inside azure/cli container#145
jschoedl merged 1 commit into
mainfrom
fix/azure-oidc-in-container

Conversation

@jschoedl

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #144. The container CLI still failed at login: azure/login ran on the host with a newer MSAL and wrote a token cache the pinned container CLI (2.64.0 / Python 3.9) couldn't deserialize (NormalizedResponse AttributeError). Drop azure/login; instead fetch the GitHub OIDC token on the host and run az login --service-principal --federated-token inside the container, so one CLI/MSAL version both authenticates and runs the commands. Applied to all three workflows.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Infrastructure / CI
  • Documentation

API changes

  • This PR does not affect the API
  • This PR changes the API → api/openapi.yaml updated and api/scripts/gen-all.sh re-run

Definition of Done

  • CI passes
  • Pre-commit hooks pass locally
  • Relevant tests added or updated

The host azure/login wrote an MSAL token cache the older container CLI
(2.64.0) could not read (NormalizedResponse AttributeError). Drop
azure/login; fetch the GitHub OIDC token on the host and run
az login --federated-token inside the container so one CLI/MSAL version
both authenticates and runs the commands.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jschoedl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6c4aba65-1dd1-4dc3-add2-5e155edb0fbd

📥 Commits

Reviewing files that changed from the base of the PR and between e5d0ce5 and 8b7de27.

📒 Files selected for processing (3)
  • .github/workflows/deploy-ansible.yml
  • .github/workflows/vm-start.yml
  • .github/workflows/vm-stop.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/azure-oidc-in-container

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jschoedl
jschoedl merged commit 8e495f1 into main Jul 19, 2026
1 check passed
@jschoedl
jschoedl deleted the fix/azure-oidc-in-container branch July 19, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant