Skip to content

fix ingress buffer size#125

Merged
raphael-frank merged 1 commit into
mainfrom
infra/120-remove-hardcode-secrets
Jul 10, 2026
Merged

fix ingress buffer size#125
raphael-frank merged 1 commit into
mainfrom
infra/120-remove-hardcode-secrets

Conversation

@raphael-frank

@raphael-frank raphael-frank commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

I fixed an issue regarding the ingress buffer

Summary by CodeRabbit

  • Bug Fixes
    • Improved authentication flow reliability by increasing proxy header capacity when forward authentication is enabled.
    • Prevented login and session refresh failures caused by oversized authentication headers.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b167642a-f313-46a2-9cf2-7de67b526033

📥 Commits

Reviewing files that changed from the base of the PR and between ccfe450 and 45cc4c2.

📒 Files selected for processing (1)
  • infra/helm/team-devoops/templates/ingress.yaml

📝 Walkthrough

Walkthrough

The Helm ingress template adds a conditional 16k nginx proxy buffer annotation to both team-devoops-plain and team-devoops-open when forwardAuth is enabled, with comments describing oauth2-proxy header-size failures.

Changes

Ingress proxy buffer configuration

Layer / File(s) Summary
Forward-auth ingress annotations
infra/helm/team-devoops/templates/ingress.yaml
Both ingress variants add nginx.ingress.kubernetes.io/proxy-buffer-size: "16k" alongside the oauth2-proxy annotations when forwardAuth is enabled, with explanatory comments.

Estimated code review effort: 2 (Simple) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: increasing the ingress proxy buffer size to fix nginx header issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch infra/120-remove-hardcode-secrets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@raphael-frank
raphael-frank merged commit bc18c6c into main Jul 10, 2026
16 checks passed
@raphael-frank
raphael-frank deleted the infra/120-remove-hardcode-secrets branch July 10, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant