Repository navigation
Use fast-xml-parser for all XML parsing - #55
Merged
Merged
Conversation
The Gridset/Snap/TouchChat validators used xml2js, which requires the Node core modules events and timers (and its sax dependency requires stream). Metro cannot resolve those in React Native/Expo, so the browser distribution could not be bundled and needed Vite polyfills/aliases for web. Add a shared src/utils/xml.ts wrapper around fast-xml-parser (already a dependency and Node-free) configured to keep the xml2js output shape: attributes grouped under $, every non-root element always an array, and string values. Well-formedness is checked with XMLValidator first because fast-xml-parser is permissive. Update the three validators and drop xml2js, its @types (which was wrongly listed as a runtime dependency), and the transitive sax/xmlbuilder packages. All 847 tests pass.
chrisbaume
changed the title
Collaborator
|
Thanks Chris — nice work keeping the xml2js-compatible shape (the array-wrapping via isArray is a clever emulation). Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are two XML parsers - fast-xml-parser and xml2js. However, xml2js includes node.js dependencies so can't be compiled for React Native. This update removes xml2js and uses fast-xml-parser for all XML parsing. This is done via a function that emulates xml2js's behaviour, including validating the string and throwing an error if it fails.