Conversation
…ths and verification steps for protobuf files
…vo center offset definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves CI coverage for firmware and protobuf changes by updating and adding GitHub Actions workflows, as well as enabling servo center offset configuration in the firmware. The main changes include expanding the typecheck workflow to cover more files, introducing a dedicated PlatformIO build workflow, and ensuring that generated protobuf files are always up to date.
CI workflow improvements:
.github/workflows/pr-lint-typecheck.ymlworkflow to trigger on changes to additional files and directories, includingMakefile,platformio.ini,protobuf/**, and firmware-related paths, ensuring more comprehensive lint and typecheck coverage.stackchan_server/generated_protobufandfirmware/lib/generated_protobufare up to date, failing the job if not..github/workflows/pr-platformio-build.ymlworkflow that builds the firmware using PlatformIO on every relevant push or pull request, ensuring build integrity for firmware changes.Firmware configuration:
SERVO_SG90_X_CENTER_OFFSETandSERVO_SG90_Y_CENTER_OFFSETdefinitions by default infirmware/include/config.template.h, allowing servo center offsets to be configured without manual uncommenting.