Decorate GZIPInputStream with DigestInputStream, not the other way around.#94
Closed
drasmart wants to merge 1 commit into
Closed
Decorate GZIPInputStream with DigestInputStream, not the other way around.#94drasmart wants to merge 1 commit into
GZIPInputStream with DigestInputStream, not the other way around.#94drasmart wants to merge 1 commit into
Conversation
Contributor
Unit Tests - Ubuntu_Java_17269 tests - 139 255 ✅ - 151 14s ⏱️ -37s For more details on these failures and errors, see this check. Results for commit 726115e. ± Comparison against base commit c7906dd. This pull request removes 139 tests. |
Contributor
Unit Tests - MacOS_Java_11269 tests - 139 250 ✅ - 151 9s ⏱️ -43s For more details on these failures and errors, see this check. Results for commit 726115e. ± Comparison against base commit c7906dd. This pull request removes 139 tests. |
Contributor
Unit Tests - Ubuntu_Java_11269 tests - 139 255 ✅ - 151 16s ⏱️ -35s For more details on these failures and errors, see this check. Results for commit 726115e. ± Comparison against base commit c7906dd. This pull request removes 139 tests. |
Contributor
Unit Tests - Ubuntu_Java_8269 tests - 139 255 ✅ - 151 16s ⏱️ -31s For more details on these failures and errors, see this check. Results for commit 726115e. ± Comparison against base commit c7906dd. This pull request removes 139 tests. |
Contributor
Unit Tests - MacOS_Java_17269 tests - 139 250 ✅ - 151 11s ⏱️ -51s For more details on these failures and errors, see this check. Results for commit 726115e. ± Comparison against base commit c7906dd. This pull request removes 139 tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GZIPInputStreamwithDigestInputStream.Why
pipeline-java/pipeline.engines/src/main/java/fiftyone/pipeline/engines/services/DataUpdateServiceDefault.java
Lines 636 to 640 in c7906dd
DigestInputStreamreceives uncompressed data.