Conversation
3AHAT0P
reviewed
Jan 18, 2020
Comment on lines
+66
to
+75
| return (async () => { | ||
| if (typeof mainSprite === 'string') this.mainSprite = await this._loadImage(mainSprite); | ||
| if (moveSprite instanceof Object) this.moveSettings.moveSprite = await this._loadDynamicSprite(moveSprite, moveSpriteMeta); | ||
| if (jumpSprite instanceof Object) this.jumpSettings.jumpSprite = await this._loadDynamicSprite(jumpSprite, jumpSpriteMeta); | ||
| if (attackSprite instanceof Object) this.attackSettings.attackSprite = await this._loadDynamicSprite(attackSprite, attackSpriteMeta); | ||
|
|
||
| this._offscreenCanvas = new OffscreenCanvas(this.mainSprite.width, this.mainSprite.height); | ||
|
|
||
| return this; | ||
| })(); |
Owner
There was a problem hiding this comment.
Please use async create function (aka fabricMethod) instead of async constructor
Dev: add static create method for Character.js Dev: add validations for flipbooks Dev: add static create method for Flipbook.js Dev: add Sprite class
Dev: add jsdoc description for Character.create method
Dev: fix jsdoc description for Character.create method Dev: add jsdoc description for Character constructor
Dev: refactor Flipbook.js
Dev: add start\stop methods for Flipbook.js
Dev: fix stop method in Flipbook.js
Dev: add position to Character.js
Dev: add _offscreenCanvas
Dev: add actionHandling(not finished yet) - Character.js Dev: add _offscreenCanvas - Flipbook.js Dev: add currentSprite getter - Sprite.js
Dev: add speed for Character.js Dev: add functionality to set sprites for different directions in Character.js Dev: add render method in Character.js Dev: add _render method in Flipbook.js
Dev: bug fix Dev: memory leaks fix
Dev: fix mirroring. But it's hard code now. This settings should be passed through a some options. TBD
Dev: refactor folders and file names
Dev: add event handling to Flipbook.js Dev: fix _setOnChangeJumpFrame functionality in Character.js
Dev: add keypress event handling for jump Dev: add check position to Scene
Dev: fix all move and jump bugs
Dev: add check any collisions in move process of Character.js Dev: add addObject for Scene Dev: add collisions detection functionality in Scene
Dev: add method to render objects in Scene Dev: fix _changePosition in Character.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.