feat(storage): add content_filters to DynamoDbChatStorage#537
Open
nuthalapativarun wants to merge 1 commit into
Open
feat(storage): add content_filters to DynamoDbChatStorage#537nuthalapativarun wants to merge 1 commit into
nuthalapativarun wants to merge 1 commit into
Conversation
Adds an optional content_filters parameter — a list of (original, placeholder) pairs — to DynamoDbChatStorage. Sensitive values are replaced with their placeholders before writing to DynamoDB and restored on every read path (fetch_chat, fetch_chat_with_timestamp, fetch_all_chats). Closes 2FastLabs#131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link (REQUIRED)
Fixes #131
Summary
Changes
Adds an optional
content_filtersparameter toDynamoDbChatStorage— a list of(original, placeholder)string pairs. When provided:save_chat_message,save_chat_messages): each original value is replaced by its placeholder before the message is written to DynamoDB.fetch_chat,fetch_chat_with_timestamp,fetch_all_chats): placeholders are restored to their original values before returning to the caller.This eliminates the need for a custom storage implementation when sensitive content (e.g. company names, tokens) must not be persisted in plain text.
User experience
Before: users had to subclass
DynamoDbChatStorageor write a custom storage class to mask sensitive values.After:
DynamoDB stores
#COMPANY#; the agent always seesacme-corp.Checklist
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.